search

nyghtly-derek / itchio-bundle-claimer

Auto-claim all games from an itch.io bundle, adding them to your library. For example, "Bundle for Ukraine."
25 stars 1 forks source link

Not claiming any games, just looping through the bundle pages #17

Closed awful-falafel closed 4 months ago

awful-falafel commented 4 months ago 
(page load)--page loaded--
(new url)https://itch.io/bundle/download/hVmfqQfiwbOHQQupBQTfc_aaBuZp6tNhRN0zZo15
get.pager_label a
eq0
invoke.text()
tasklog, page 1 of 34
getbody
geta.next_page
click
(page load)--page loaded--
(new url)https://itch.io/bundle/download/hVmfqQfiwbOHQQupBQTfc_aaBuZp6tNhRN0zZo15?page=2

It doesn't click a single download button, it just fires through each of the bundle pages.

nyghtly-derek commented 4 months ago

Hi @awful-falafel,

You're mistaken about "sneaking in a creator follow." The XHR request that you mention is automatically triggered when visiting the itch.io homepage. It's completely unrelated to the Cypress script. Look here, you can see it in the dev console:

image

Moreover, you can confirm that no follow action is taking place. Take a look at the code in this repository. Do you see any selector that matches a follow button? How about a web request to follow someone? How about a page where the follow button exists? It's all there, plain as day.

--

Now, as for your bug report. It's possible that the interface has changed, or maybe just the underlying html structure. This is a common thing for a Cypress test to flake on.

Our Cypress script is looking for a button[value=claim] selector, which makes me think that there used to be some kind of "Claim" button or something like that. If that button doesn't exist anymore, then it would break the script.

Perhaps you can help me out. I've already claimed all of my games, so it's hard for me to test this. In order to claim a game, do you just need to click the "Download" button? Can you verify that this will add a game to your library? If so, then I can go in there and update the script.

awful-falafel commented 4 months ago

Nope, you're absolutely right. Seems I saw wrong, there is no bit of script to follow someone. I dug through it and ran a few more tests, and it didn't do what I thought I saw originally. I apologize, that was pretty rude.

As far as claiming yeah, you just need to hit the Download button. Stranger though is I tried it with another bundle (maybe I already claimed all my Ukraine bundle games?) and it skipped all them as well, but two did download.

Not sure why it would click those two and none of the rest, though.

awful-falafel commented 4 months ago

Actually no, this has to be my mistake (seems like a theme, huh), as it seems to be working entirely fine on this new Palestine Relief bundle.

I have zero recollection of already downloading the entirety of those last two bundles, but perhaps I had?

Either way, you might avoid another dummy like myself if you put a 'IT WILL SKIP ITEMS YOU'VE PREVIOUSLY DOWNLOADED' line in the Readme.

Cheers, mate. Sorry again! 🍻

nyghtly-derek commented 4 months ago

Falafel, I deeply appreciate your humility to admit a mistake! And thank you so much for testing it out on a new bundle. I was planning to do that next, so you've saved me a lot of time.

I'm guessing that the "Claim" button becomes a "Download" button after you click it, or something like that. I cannot believe that you manually clicked through every item in the Ukraine bundle at some time in the past. That must have taken so long! 😅

I'll add something to the readme for clarity.