nyholku / purejavacomm

Pure Java implementation of JavaComm SerialPort
http://www.sparetimelabs.com/purejavacomm/index.html
BSD 3-Clause "New" or "Revised" License
367 stars 146 forks source link

JNA 4.0/5.0 Compatibility #112

Closed PeteSL closed 6 years ago

PeteSL commented 6 years ago

JNA 5.0 removed deprecated Native.setPreserveLastError which was simply a NOOP in JNA 4.0. JNA 5.0 removed deprecated Pointer.SIZE which was replaced by Native.POINTER_SIZE in JNA 4.0.

nyholku commented 6 years ago

Is this backwards compatible with 4.0 i.e. would not affect current users? And thanks for the work!

PeteSL commented 6 years ago

Yes, it is compatible with 4.0. setPreserveLastError was no-op'ed in 4.0 (we had added it for 3.x) and Native.POINTER_SIZE was introduced in 4.0 to deprecate Pointer.SIZE (I think their philosophy was that it should have been under Native for consistency).

nyholku commented 6 years ago

Thanks! I will try to find time to do release in about three weeks, if you do not hear back from me, give me a nudge.