Added nonblocking flag check on create file in windows impl.

nyholku / purejavacomm

Pure Java implementation of JavaComm SerialPort

http://www.sparetimelabs.com/purejavacomm/index.html

BSD 3-Clause "New" or "Revised" License

362 stars 146 forks source link

Added nonblocking flag check on create file in windows impl. #127

Closed pmdwyer closed 5 years ago

pmdwyer commented 5 years ago

The Windows JTermios implementation didn't honor the non-blocking/no-delay flag. This change fixes that, so the create file call to the Win32 API now results in a blocking read and write when that flag is not present.

nyholku commented 5 years ago

So this does nothing for PJC, only to make the Windows JTermios implementation more consistent, right?

Have you tested this?

Looks ok and acceptable to me,

pmdwyer commented 5 years ago

Yes, in addition to the provided test suite, I wrote a simple loopback test that I was using.

nyholku commented 5 years ago

Ok, thanks!