nyjalusc / TwitterClient

MIT License
0 stars 0 forks source link

[Android Bootcamp] Project 4: Twitter Client with Fragments - Ready for review #1 #2

Open nyjalusc opened 9 years ago

nyjalusc commented 9 years ago

Hey Guys, my work is complete and ready to be reviewed. /cc @codepathreview @codepath

nyjalusc commented 9 years ago

I wanted to add that i had a hard time making the profile activity look pretty. After putting in all the required info there was hardly any space left to show the list of tweets. I gave a shot at using a combination of ScrollView with an embedded listview to mimic what twitter does today. But my efforts went in vain. After giving a fair shot, i found that embedding a listview in a scrollview is an anti-pattern. Nathan did explain to me what Twitter is using to achieve that effect of scrolling, the magic lies in listview headers!! I gave up the idea and polished the screen to the best of my abilities. In order to save some screen space i am not showing one of the required info, tagline, and instead i am showing a profile banner to make it appear pretty. Not all users have taglines, but everyone does have a profile banner. Even if you don't set it up Twitter shows a default placeholder which helps you achieve a consistent view across profile activity of all users. So, purely on the grounds of making my app pretty i made the decision of not showing the tagline. I hope that is cool with you guys.

Thanks.

codepathreview commented 9 years ago

:+1: Excellent work, appreciate all the efforts that you put in these assignments outside of your full-time job. A few notes after checking out the code:

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp, we are going to have a public demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.