search

nylas-mail-lives / nylas-mail

:love_letter: An extensible desktop mail app built on the modern web.
MIT License
474 stars 63 forks source link

Support for Custom Ports #120

Closed OmarAssadi closed 7 years ago

OmarAssadi commented 7 years ago

Hey!

It would be great if someone could add support for non-standard ports when configuring an email account. In my particular case, it makes it mildly annoying to use ProtonMail as their bridge software defaults to 1143 and 1025 for the incoming/outgoing ports.

Also, this affects signifcantly more people than simply ProtonMail users. Many organizations change their mail server ports—which makes Nylas unusable without using inspect element or something. See: nylas/nylas-mail#3424

OmarAssadi commented 7 years ago

Added a small bounty: current bounty

OmarAssadi commented 7 years ago

Pinging @axelvnk - Hey! I saw that you made a pull request on the main Nylas Mail repository (nylas/nylas-mail#3640). It doesn't appear that there is any real activity there, though.

Figured I'd see if you would like to make that pull request here before I go ahead and make my own.

axelvnk commented 7 years ago

@54 I'll do it tonight :)

kaustav1996 commented 7 years ago

@axelvnk did you do it?

mikeseese commented 7 years ago

@dweremeichik would you want this to remove the dropdown in place of a text field for port number? Or would we rather have the dropdown with "Custom..." which shows the input field and allows for input? The latter I think is better, but will require some extra work

dweremeichik commented 7 years ago

I'm behind the latter. The other option allows for too much error. It's hard enough for most to set up email as it is. To be honest there has been times when I have forgotten which port my provider used in the past, simple solution was to try each available option. Can't do that with a text box.

mikeseese commented 7 years ago

agreed; therefore i dont think the PR at https://github.com/nylas/nylas-mail/pull/3640 is sufficient. i've got some time tonight to work this. still need my 4 PRs for the month >.>

that is if @axelvnk doesnt want to work it

mikeseese commented 7 years ago

i went ahead and started this

mikeseese commented 7 years ago

Here's what it looks like:

peek 2017-10-25 23-20

dweremeichik commented 7 years ago

Well done! I'm :+1: on this.