Calendar Invites don't show up in the body

nylas-mail-lives / nylas-mail

:love_letter: An extensible desktop mail app built on the modern web.

MIT License

474 stars 63 forks source link

Calendar Invites don't show up in the body #132

Open nirmit opened 6 years ago

nirmit commented 6 years ago

The body shows as blank. It seems to be an issue with the "events" attribute in the message object. This is specific to ICS invite based emails.

This issue can be split up into the below desired functionality:

[x] (@nirmit completed) Show ICS as attachment
[x] (@nirmit completed) Show invite content (date, time, timezone if specified, name, location, description, etc) with no action buttons
[ ] (Unassigned) Implement RSVP action buttons

nirmit commented 6 years ago

As a starting point, we can atleast show the ICS as an attachment. What do you guys think, @seesemichaelj @dweremeichik ?

mikeseese commented 6 years ago

hm i want to say i've seen this issue, but sending myself a calendar invite from google calendar didn't work (i was able to receive an invite.ics attachment as well as a email of the details of the invite). are you able to recreate this?

i agree, that at a minimum, the ICS should show as an attachment

a nicer improvement would have a dedicated header at the top of the invite that had parsed info from the ICS attachment

we can separate these as two separate issues if desired

nirmit commented 6 years ago

Yes. The reason the Calendar invite works from Google is because the ICS is an attachment to the HTML invitation content that comes along. If you use exchange, you will see that the ICS is not correctly parsed.

I agree on showing the invite content inline in a better way, but I am not sure if I would be able to implement invite actions - Accept, Tentative or Decline! :(

mikeseese commented 6 years ago

well i think there's three different iterations of this:

show ICS as attachment
show invite content (date, time, timezone if specified, name, location, description, etc) with no action buttons
implement RSVP action buttons

I'll add these as checkboxes in your first comment on this Issue, and people can "pick" which ones they want to work on, and they'll get checked when merged

nirmit commented 6 years ago

Great! I can work on the ICS attachment one.

mikeseese commented 6 years ago

ICS attachment completed in #133

nirmit commented 6 years ago

In order to complete pt. 2 from the list above, I would suggest including the meeting content along with the attachments. Since the meeting header wouldn't have any actionable buttons, the users can still open the .ics to accept/decline meetings. Let me know if it makes sense.

mikeseese commented 6 years ago

I agree

dweremeichik commented 6 years ago

Auto closed by merge. Reopening.