search

nylas-mail-lives / nylas-mail

:love_letter: An extensible desktop mail app built on the modern web.
MIT License
474 stars 63 forks source link

Issue in FileDownloadStore that forces re-download of files #189

Closed nirmit closed 6 years ago

nirmit commented 6 years ago

This is a weird issue that I have been facing but didn't have the time to dig into. The way the FileDownloadStore checks, if the file is already downloaded, seems to be broken (or it's just me!).

The _checkForDownloadedFile method checks for the file size in the ~/.nylas-mail/downloads directory and the file size captured from the header. If the file sizes are same, it won't initiate a download, else it would. In my case, none of the attachments has the same file size (physical) as the size mentioned in the header! Therefore, Nylas always re-downloads the file and re-write the physical one. This also delays the availability of the attachment in case of large files.

Does this sound familiar? Is anyone else facing the same issue?

mikeseese commented 6 years ago

I definitely will say the way downloads works in general seems kludgy. Many times the file is "downloaded" with 0 bytes; I have to quit nylas and that sometimes fixes it. It might be worth it to do a full review of the code and clean up stuff and make it stable. I don't know if my issue is similar to your issue however

nirmit commented 6 years ago

It happens to me almost all the time with large files (>2MB)...

Also, can you please remove the contributor wanted label?