search

nylas-mail-lives / nylas-mail

:love_letter: An extensible desktop mail app built on the modern web.
MIT License
474 stars 63 forks source link

Setup code coverage & reporting. #40

Open dweremeichik opened 7 years ago

dweremeichik commented 7 years ago

It has become apparent that we need proper automated testing and code coverage reports. This issue is a request for the latter.

asaphaaning commented 7 years ago

With limited time over the summer and a conflicting lust to participate in this, maybe this is a small problem I can assist with in the coming months.

Do we need large automation systems like jenkins/buildbot or could something built ourselves do the trick, something like hack of cron and some scripting? The reason I ask this is because I haven't built it myself yet so I don't know how many processes goes into it and how the testbench is performed.

dweremeichik commented 7 years ago

I was thinking along the lines of using Istanbul's NYC and coveralls. I don't think it should be too crazy to setup. We already use Travis and are in the process of setting up appveyor, so testing isn't a problem, there really aren't many tests at this point though.

kontrollanten commented 7 years ago

Is there any tests at all written today? I can make a PR with nyc and coveralls, but as far as I understand the only tests that runs within the npm test commands are electrons internal tests? When I run the coverage I get 0. But at least there's something to start with. :-)

dweremeichik commented 6 years ago

Sorry, missed your comment on this. Yeah, there aren't really many tests at this point. The ones that do exist may not cover much.