nylas / nylas-mail

:love_letter: An extensible desktop mail app built on the modern web. Forks welcome!
https://nylas.com/nylas-mail/
MIT License
24.8k stars 1.38k forks source link

Feature Request: Add RTL (right to left language) support #124

Open liorkesos opened 9 years ago

liorkesos commented 9 years ago

RTL is an important (and shuold be easy feature) for mideast languages (hebrew, persian, arabic) This issue was closed in a previous bug and is a seperate issue from language translation.

alonisser commented 9 years ago

+1

Leonid99 commented 8 years ago

+1

yasharne commented 8 years ago

+1

elado commented 8 years ago

+1

elado commented 8 years ago

Text inputs on Mac apps have this ability in the context menu:

screen shot 2015-11-30 at 1 13 56 pm

But seems like N1 overrides this menu

screen shot 2015-11-30 at 1 14 48 pm

It would be great just to bring it back until a more permanent solution is introduced.

grinich commented 8 years ago

Hi @elado. N1 isn't a normal Mac App -- under the hood it's running Chromium and JavaScript. This means we don't use the Cocoa text boxes which come with regular contextual menus, so the fix isn't so simple.

elado commented 8 years ago

Is it a limitation of Electron? The screenshot was taken from Safari, and Chrome has it on all inputs too.

grinich commented 8 years ago

As far as I know, yes. Electron is pretty minimal. It uses the Chromium Embedded Framework which is essentially just the view rendering code underneath Chrome and not the native OS integration.

royts commented 8 years ago

+1

mehrancodes commented 8 years ago

+1

rauchy commented 8 years ago

+1

oyagev commented 8 years ago

+1 on Linux

krugi commented 8 years ago

+1

hadifarnoud commented 8 years ago

It's a good idea to do what Gmail does for text direction. they switch the direction based on characters typed.

you can find an example here: http://codepen.io/siamak/pen/rAmBb

UPDATE: this one is actually supports all RTL languages https://github.com/hasenj/bidiweb

obahareth commented 8 years ago

+1

hadifarnoud commented 8 years ago

can we get an ETA on this? This is the only blocking issue for me to fully switch to N1

heyanlong commented 8 years ago

+1

OhadRon commented 8 years ago

+1

dortheimer commented 8 years ago

+1

argamanza commented 8 years ago

+1 Writing a mail which involves both English and Hebrew is just a nightmare.

amijafari commented 8 years ago

+1

hugoalmeidahh commented 8 years ago

+1

sajadshokri commented 8 years ago

+1

1001adi commented 8 years ago

+1 !!!!

amig commented 8 years ago

Until a good working solution is available, I would like to suggest the following workaround: Enable the "Quick Replies" plug-in. The templates are saved in ~/.nylas/templates

Create a file: RTL.html and paste into it: <div style="direction:rtl;text-align:right;"><div>RTL</div></div>

Now, the first thing you do when creating a new email, select the RTL quick reply and wallah.

ronshoshani commented 8 years ago

+1

msudgh commented 8 years ago

To add this feature just you need to detect Mideast ASCII, after that if it was Mideast, ok, add dir="rtl" to div. like this => http://codepen.io/siamak/pen/rAmBb

nournia commented 8 years ago

Using dir=auto may helps. You can check out its documentation: https://html.spec.whatwg.org/multipage/dom.html#the-dir-attribute

msudgh commented 8 years ago

@nournia yeah, it's possible and maybe better choice to fix this issue

eyalw commented 7 years ago

+1

mequ commented 7 years ago

+1

alono commented 7 years ago

+1 Just started using it, but RTL will make me remove thunderbird :)

clockworkpc commented 7 years ago

@amig Thanks, this is a great little workaround! תודה אחי

hadifarnoud commented 7 years ago

I wrote an example here https://codepen.io/hadifarnoud/pen/rmdxWe

On 22 Sep 2017 at 09:48, Alexander Garber notifications@github.com wrote:

@amig https://github.com/amig Thanks, this is a great little workaround! תודה אחי

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nylas/nylas-mail/issues/124#issuecomment-331360351, or mute the thread https://github.com/notifications/unsubscribe-auth/AAj_8BIpqk50hjy9WtjMhHl0q5KD-3DPks5sk1ExgaJpZM4GTimm .

moughxyz commented 6 years ago

@nournia dir=auto works wonderfully. Added it to the Standard Notes web client https://github.com/standardnotes/web