nylas / nylas-mail

:love_letter: An extensible desktop mail app built on the modern web. Forks welcome!
https://nylas.com/nylas-mail/
MIT License
24.79k stars 1.37k forks source link

Windows Store/APPX for deployment? #1313

Open bherila opened 8 years ago

bherila commented 8 years ago

Pros:

Cons:

bherila commented 8 years ago

This would also probably mean using Windows JS engine (Chakra) as opposed to Chromium on Windows. Not sure if that would be a huge issue but it might impact https://github.com/nylas/N1/issues/178

mbilker commented 8 years ago

This would require a complete rewrite of N1 to use a different set of APIs as N1 uses Electron to provide a native interaction and access to native APIs from a Chromium instance.

bherila commented 8 years ago

It would have to be done at the Electron level, not at the N1 level.

bherila commented 8 years ago

Mac app store is a similar issue with Electron: https://github.com/electron/electron/issues/249

kevinmartin commented 8 years ago

No need to change anything in Electron: https://github.com/CatalystCode/electron-windows-store

bherila commented 8 years ago

Ooh nice. But that will only work with Windows 10, the legacy installer will still be needed for Windows 8 and 8.1.

kevinmartin commented 8 years ago

Unless you have a better solution that doesn't require rewriting the entire codebase for a non-existent Chakra plugin for Electron, that's the best we can do for now.

Electron doesn't have AppX on the radar for now I don't think.

You can probably go on that repo and post an issue to add support for Windows 8/8.1.

bengotow commented 8 years ago

Hey folks—https://github.com/CatalystCode/electron-windows-store is a project we've talked to @felixrieseberg about and we're excited to try it out. We'll definitely see if we can use it with N1 soon. I'm not sure whether Windows 8 is on their roadmap, but we'd be fine using the legacy installer.

felixrieseberg commented 8 years ago

Yo @bengotow, we can totally see if this works by just hanging out for three hours or so once I'm back from Europe (in roughly two weeks). Here's some real quick information:

The biggest blocker right now is that we haven't yet firmly decided how the path to the Windows Store looks like from a submission point of view. However, if you have anyone who's job it is to roll this out to a bazillion machines, the appx will already work if installed via sideloading (bypassing the store).