nylas / nylas-mail

:love_letter: An extensible desktop mail app built on the modern web. Forks welcome!
https://nylas.com/nylas-mail/
MIT License
24.81k stars 1.38k forks source link

Automatic linking doesn't work properly #1733

Closed jackiehluo closed 8 years ago

jackiehluo commented 8 years ago

Weirdness with links, probably because we switched from Autolinker. Some detected links (i.e., the links to diffs on Phabricator) aren't clickable, even though they look like they should be, and some arbitrary strings are detected as links.

screen shot 2016-03-14 at 8 33 13 pm

Here, the first link will launch %20spacings-sub-double. in Chrome, and the second goes to %20sure..

bengotow commented 8 years ago

Whoa that's super weird! Let's look at this tomorrow...

bengotow commented 8 years ago

Fixed in 92e8a2a7d47504195cb2a2f24f825bd83852a3d1

bengotow commented 8 years ago

Hey! This shipped in 0.4.19 a few minutes ago. You can grab the update by choosing "Check for Updates" from the menu or download the new version directly from the releases section of the project. Enjoy!