Links don't display correctly in message (e.g. Twitter, Medium) (Autolinker)

nylas / nylas-mail

:love_letter: An extensible desktop mail app built on the modern web. Forks welcome!

https://nylas.com/nylas-mail/

MIT License

24.81k stars 1.38k forks source link

Links don't display correctly in message (e.g. Twitter, Medium) (Autolinker) #1842

Closed jweinstein closed 8 years ago

jweinstein commented 8 years ago

likely others?

kevinmartin commented 8 years ago

Similar to #1840

jstejada commented 8 years ago

hey guys, thanks for reporting this. I'm merging #1840 into this one and renaming it. We'll look into it

arturogh commented 8 years ago

Great! Thanks guys!

koterpillar commented 8 years ago

HTTP links with port in them don't link correctly either, e.g. http://example.com:8080/path/ only links http://example.com.

bengotow commented 8 years ago

Hey folks—thanks! I've incorporated these into new test cases and fixed our autolinker in c836310fac42296be48b57870b3d3c0d75aced2b. Cheers!

mscain commented 8 years ago

I encountered a similar issue today with partial linking: https://www.example.ly/path only linked to https://www.example When I was composing the message, the "ly" part got underlined as a spelling error, which may be related

bengotow commented 8 years ago

Hey folks! A fix for these link-parsing issues shipped in 0.4.25, which will be hitting the auto-updaters soon. (If you want you can grab the update now on the Releases page.) Give it a spin, and feel free to re-open if you run into the issue again. Cheers—enjoy the update!