nylas / nylas-mail

:love_letter: An extensible desktop mail app built on the modern web. Forks welcome!
https://nylas.com/nylas-mail/
MIT License
24.8k stars 1.38k forks source link

Removing N1 as default mail client sets Thunderbird as default on Linux #2876

Open hallamoore opened 8 years ago

hallamoore commented 8 years ago

This is an okay solution, but it would be ideal if we could just leave the default blank. It's especially weird when the user doesn't actually have Thunderbird installed.

jackiehluo commented 8 years ago

what

hallamoore commented 8 years ago

Ubuntu's factory default is Thunderbird, and the way we set the default applications doesn't have an easy option to set a default as blank. shrugs

bengotow commented 8 years ago

This is definitely the case - caused by this line of code here: https://github.com/nylas/N1/blame/master/src/launch-services.coffee#L30.

I couldn't find a way to reset the default mail client (had to set it to /something/), so I picked Thunderbird because it was what the preferences app chose on my Ubuntu distro. We might be able to save what was the default before N1 becomes the default, but I'm not sure it's worth it!

hallamoore commented 8 years ago

I haven't been able to find a way to set it to nothing, but setting it to a fake application seems to work well. At least on Ubuntu, it's able to fall back to an actual application that does exist. So maybe we should just set it to placeholder.desktop or something.