nylas / nylas-mail

:love_letter: An extensible desktop mail app built on the modern web. Forks welcome!
https://nylas.com/nylas-mail/
MIT License
24.81k stars 1.37k forks source link

Quote text and attachment missing #3429

Open ccpost opened 7 years ago

ccpost commented 7 years ago
Are there any related issues?

Possibly #2537

What operating system are you using?

macOS Sierra (10.12.4)

What version of Nylas Mail are you using?

2.0.15

Bug?

Do you have any third-party plugins installed? If so, which ones?

None

Is the issue related to a specific email provider (Gmail, Exchange, etc.)?

Gmail (no other provider available to compare)

Is the issue reproducible with a particular attachment, message, signature, etc?

An email in a thread is missing:

The thread has multiple back-and-forth quotes, and previous emails in the chain show up properly.

The same email shows up properly in Nylas N1 (v1.5.0).

I can't post the whole email, but here's a redacted version lacking headers:

--Apple-Mail=_854913B1-91AF-432B-B4EC-7CD79AAB8A3A
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

REDACTED PLAINTEXT EMAIL - NEW BODY AND QUOTE CHAIN

--Apple-Mail=_854913B1-91AF-432B-B4EC-7CD79AAB8A3A
Content-Type: multipart/mixed; boundary="Apple-Mail=_6B98F2A6-AAC7-4FA8-AA9E-09BCD8ABB0D4"

--Apple-Mail=_6B98F2A6-AAC7-4FA8-AA9E-09BCD8ABB0D4
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8

REDACTED HTML EMAIL - NEW BODY (NO QUOTE CHAIN)

--Apple-Mail=_6B98F2A6-AAC7-4FA8-AA9E-09BCD8ABB0D4
Content-Disposition: inline; filename="REDACTED WITH ONLY ASCII CHARACTERS.pdf"
Content-Type: application/pdf; x-unix-mode=0644; name="REDACTED WITH ONLY ASCII CHARACTERS.pdf"
Content-Transfer-Encoding: base64

--Apple-Mail=_6B98F2A6-AAC7-4FA8-AA9E-09BCD8ABB0D4
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8

REDACTED HTML EMAIL - JUST QUOTE CHAIN

--Apple-Mail=_6B98F2A6-AAC7-4FA8-AA9E-09BCD8ABB0D4--
--Apple-Mail=_854913B1-91AF-432B-B4EC-7CD79AAB8A3A--

And a simpler case with more details that happens to trigger the missing attachment case:

Delivered-To: RECIPIENT@REDACTED.COM
Received: by IP_REDACTED with SMTP id o139csp371908itc;
        Wed, 19 Apr 2017 11:40:55 -0700 (PDT)
X-Received: by IP_REDACTED with SMTP id m7mr3228250ywf.20.1492627255645;
        Wed, 19 Apr 2017 11:40:55 -0700 (PDT)
Return-Path: <SENDER@REDACTED.COM>
Received: from DNS_REDACTED (DNS_REDACTED [IP_REDACTED])
        by mx.google.com with ESMTPS id t3si1414783ywd.456.2017.04.19.11.40.55
        for <RECIPIENT@REDACTED.COM>
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 19 Apr 2017 11:40:55 -0700 (PDT)
Received-SPF: pass (google.com: domain of SENDER@REDACTED.COM designates IP_REDACTED as permitted sender) client-ip=IP_REDACTED;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@gmail.com;
       spf=pass (google.com: domain of SENDER@REDACTED.COM designates IP_REDACTED as permitted sender) smtp.mailfrom=SENDER@REDACTED.COM;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com
Received: by mail-yb0-x232.google.com with SMTP id 6so10887123ybq.2
        for <RECIPIENT@REDACTED.COM>; Wed, 19 Apr 2017 11:40:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=from:mime-version:subject:message-id:date:to;
        bh=UZCmb73u2zZf4gunLNPY4rkeXxyfhM8EMx83Rm0tQcM=;
        b=hjHoNUZGwULjdd7iSKnCPNYxucYlxWf0Umlj+ae9rqqT4tUbwKxw/g/W7grfuUQPgP
         c+bSy5lpvxn6cHiD6Vi6faa1rsRtDB+NF6nXCQDYPSHWbYBgSrfmjbpqq01iDL60nIjO
         mISJDFzb+wjy2i15d33jpm6fDonmb4sJ4wcKv0MhJJ74jUN+pAUuI5dUHl+A+agTtyqR
         2LKKcZZD06SVOyihNTLXaYVmZwfK4Mra4mLdJPlCUHquZ8DDF2Ac3sBp88hlo4ZfTvPY
         zEfx9JSy16cqmBIZ/jvG7INsIKvgO/9Fe4m2M7yOj9Fn7XBpubpOKlHu4exRkC+Tno6A
         wZ3A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:from:mime-version:subject:message-id:date:to;
        bh=UZCmb73u2zZf4gunLNPY4rkeXxyfhM8EMx83Rm0tQcM=;
        b=ge07v0qbcqBC5kvn+9D3+Kdo3XyD/MjXKfA3G6VJPVZ4iCIgV4gEWkzhvZ6sbZ3gWB
         l4wn1nvvdwWr87w4may/Z182fPtxLAZp1+mMLyjNegZyEzwTt0T8EL3T970PH2IMwKyy
         pyakzetlQjAmR4w/WrGabxrZGVBAoiSeMAgxm2Dd8Evrdhb5adctlBLZGwgIoB/k5Nc6
         sW9s+FV+cDb99sYL7Rci9/PN55f5Vne3LF8G2ihSwYGEyeskSu1aI+E4KunyYmbqplv8
         Up4vuEKOWFFfbAhDqFefI07RE4Zxy6o0pC/dF7TjRaDu3rI+YozLScs8oNRjYGhdNi0z
         Adxg==
X-Gm-Message-State: AN3rC/5pNY3FxmFKZMEVk1/VkSOx5AWklpGtvuAjiPL318J+B82jEpbn njBHk2X4CHuS710e+hc=
X-Received: by IP_REDACTED with SMTP id d84mr4279832pfk.7.1492627254119;
        Wed, 19 Apr 2017 11:40:54 -0700 (PDT)
Return-Path: <SENDER@REDACTED.COM>
Received: from [IP_REDACTED] (DNS_REDACTED [IP_REDACTED])
        by smtp.gmail.com with ESMTPSA id v13sm1967418pgo.44.2017.04.19.11.40.52
        for <RECIPIENT@REDACTED.COM>
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 19 Apr 2017 11:40:53 -0700 (PDT)
From: SENDER REDACTED <SENDER@REDACTED.COM>
Content-Type: multipart/mixed; boundary="Apple-Mail=_443BABAC-4940-4351-9ECA-3672950C7BBA"
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Demonstrate Nylas bug
Message-Id: <A1872F92-3BF0-4A3D-8B49-DE91A9BAE6AE@gmail.com>
Date: Wed, 19 Apr 2017 11:40:51 -0700
To: RECIPIENT REDACTED <RECIPIENT@REDACTED.COM>
X-Mailer: Apple Mail (2.3273)

--Apple-Mail=_443BABAC-4940-4351-9ECA-3672950C7BBA
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=us-ascii

Please see attached PDF below:

--Apple-Mail=_443BABAC-4940-4351-9ECA-3672950C7BBA
Content-Disposition: inline; filename=pipeline_line_map-630x420.pdf
Content-Type: application/pdf; x-unix-mode=0600; name="pipeline_line_map-630x420.pdf"
Content-Transfer-Encoding: base64

--Apple-Mail=_443BABAC-4940-4351-9ECA-3672950C7BBA--
ccpost commented 7 years ago

The more I look at this the more I'm convinced it's a duplicate of at least the Mac Mail bits of #2537. My quote text is disappearing because it's being placed below the inline attachment in the message structure.