nylas / nylas-mail

:love_letter: An extensible desktop mail app built on the modern web. Forks welcome!
https://nylas.com/nylas-mail/
MIT License
24.81k stars 1.38k forks source link

Spell check underlines words with umlauts in them #3450

Open v-ji opened 7 years ago

v-ji commented 7 years ago

I have noticed that Nylas does not correctly spell check German messages, as it seems to ignore characters with umlauts or the "ß" character in them. Note for example that the right-click menu for "Überzeugung" even brings up the same word as a suggestion.

capture

Are there any related issues?

Not that I know of.

What operating system are you using?

Windows 10.

What version of Nylas Mail are you using?

2.0.16

Do you have any third-party plugins installed? If so, which ones?

None.

Is the issue related to a specific email provider (Gmail, Exchange, etc.)?

I don't think so.

Is the issue reproducible with a particular attachment, message, signature, etc?

This is the string used in the screenshot, but any German text should work.

Alle Menschen sind frei und gleich an Würde und Rechten geboren. Sie sind mit Vernunft und Gewissen begabt und sollen einander im Geist der Brüderlichkeit begegnen.
Jeder hat Anspruch auf die in dieser Erklärung verkündeten Rechte und Freiheiten ohne irgendeinen Unterschied, etwa nach Rasse, Hautfarbe, Geschlecht, Sprache, Religion, politischer oder sonstiger Überzeugung, nationaler oder sozialer Herkunft, Vermögen, Geburt oder sonstigem Stand.
pjssilva commented 7 years ago

Same here under Linux (Ubuntu 17.04). Most words that have an accented character (not only ü) in are underlined suggesting a spelling error. Actually there is an interesting detail. Consider for example the word disponível. It shows the first part up to the í underlined, the accented letter is not underlined, and then the final part of the word is underlined. It is similar to the behavior in the screen shot above. This suggests that the spell checker is having problems to recognize the accented character and it is considering it a word break. This is further confirmed if you call the spell suggestions, they are usually associated to the first part of the word if o click before the accent and the last part if you click after.

Maybe it is an encoding problem?

shreebles commented 7 years ago

Can confirm, Windows 10 1607 and Nylas 2.0.16 here