search

nylas / nylas-mail

:love_letter: An extensible desktop mail app built on the modern web. Forks welcome!
https://nylas.com/nylas-mail/
MIT License
24.81k stars 1.38k forks source link

Bump node-keytar to latest release. #3539

Closed johnramsden closed 7 years ago

johnramsden commented 7 years ago

libsecret has been used instead of gnome-keyring in node-keytar since version 4.0.0. Moving to libsecret would be much better for users who are not using gnome, right now it means running an extra keyring.

johnramsden commented 7 years ago

Added ppa source for libsecret.

johnramsden commented 7 years ago

The Travis build seems to be failing in the package step, I'm investigating what's causing the error.

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.1.1: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: appdmg@^0.4.5 (node_modules/electron-installer-dmg/node_modules/appdmg):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for appdmg@0.4.5: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
> nylas-mail-all@0.0.1 build-client /home/travis/build/nylas/nylas-mail
> grunt build-client --gruntfile=packages/client-app/build/Gruntfile.js --base=./
Running "package" task
---> Running packager with options:
{ 'app-version': '2.0.15',
  platform: 'linux',
  protocols: 
   [ { name: 'Nylas Protocol', schemes: [ 'nylas', [length]: 1 ] },
     { name: 'Mailto Protocol', schemes: [ 'mailto', [length]: 1 ] },
     [length]: 2 ],
  dir: '/home/travis/build/nylas/nylas-mail/packages/client-app',
  'app-category-type': 'public.app-category.business',
  tmpdir: '/tmp/nylas-build',
  name: 'nylas',
  'app-copyright': 'Copyright (C) 2014-2017 Nylas, Inc. All rights reserved.',
  derefSymlinks: false,
  asar: { unpack: '{*.node,**/vendor/**,examples/**,**/src/tasks/**,**/node_modules/spellchecker/**,**/node_modules/windows-shortcuts/**}' },
  ignore: 
   [ { /.*\.watchmanconfig.*/ [lastIndex]: 0 },
     { /^\/build.*/ [lastIndex]: 0 },
     { /^\/dist.*/ [lastIndex]: 0 },
     { /^\/docs.*/ [lastIndex]: 0 },
     { /^\/docs_src.*/ [lastIndex]: 0 },
     { /^\/script.*/ [lastIndex]: 0 },
     { /^\/spec.*/ [lastIndex]: 0 },
     { /[\/]+gh-pages$/ [lastIndex]: 0 },
     { /[\/]+docs$/ [lastIndex]: 0 },
     { /[\/]+obj[\/]+gen/ [lastIndex]: 0 },
     { /[\/]+\.deps$/ [lastIndex]: 0 },
     { /\.md$/i [lastIndex]: 0 },
     { /\.log$/i [lastIndex]: 0 },
     { /\.yml$/i [lastIndex]: 0 },
     { /\.gz/i [lastIndex]: 0 },
     { /\.zip/i [lastIndex]: 0 },
     { /\.pdb$/ [lastIndex]: 0 },
     { /\.h$/ [lastIndex]: 0 },
     { /\.cc$/ [lastIndex]: 0 },
     { /\.ts$/ [lastIndex]: 0 },
     { /\.flow$/ [lastIndex]: 0 },
     { /\.gyp/ [lastIndex]: 0 },
     { /\.mk/ [lastIndex]: 0 },
     { /\.dYSM$/ [lastIndex]: 0 },
     { /node_modules[\/]+less[\/]+dist$/ [lastIndex]: 0 },
     { /node_modules[\/]+react[\/]+dist$/ [lastIndex]: 0 },
     { /node_modules[\/].*[\/]tests?$/ [lastIndex]: 0 },
     { /node_modules[\/].*[\/]coverage$/ [lastIndex]: 0 },
     { /node_modules[\/].*[\/]benchmark$/ [lastIndex]: 0 },
     { /@paulbetts[\/]+cld[\/]+deps[\/]+cld/ [lastIndex]: 0 },
     [length]: 30 ],
  out: '/home/travis/build/nylas/nylas-mail/packages/client-app/dist',
  overwrite: true,
  prune: true,
  'osx-sign': false,
  win32metadata: 
   { CompanyName: 'Nylas, Inc.',
     FileDescription: 'Nylas Mail',
     LegalCopyright: 'Copyright (C) 2014-2017 Nylas, Inc. All rights reserved.',
     ProductName: 'Nylas Mail' },
  'extend-info': '/home/travis/build/nylas/nylas-mail/packages/client-app/build/resources/mac/nylas-Info.plist',
  'app-bundle-id': 'com.nylas.nylas-mail',
  afterCopy: 
   [ { [Function: runCopyPlatformSpecificResources]
       [length]: 5,
       [name]: 'runCopyPlatformSpecificResources',
       [arguments]: null,
       [caller]: null,
       [prototype]: runCopyPlatformSpecificResources { [constructor]: [Circular] } },
     { [Function: runCopyAPM]
       [length]: 5,
       [name]: 'runCopyAPM',
       [arguments]: null,
       [caller]: null,
       [prototype]: runCopyAPM { [constructor]: [Circular] } },
     { [Function: runCopySymlinkedPackages]
       [length]: 5,
       [name]: 'runCopySymlinkedPackages',
       [arguments]: null,
       [caller]: null,
       [prototype]: runCopySymlinkedPackages { [constructor]: [Circular] } },
     { [Function: removeUnnecessaryFiles]
       [length]: 5,
       [name]: 'removeUnnecessaryFiles',
       [arguments]: null,
       [caller]: null,
       [prototype]: removeUnnecessaryFiles { [constructor]: [Circular] } },
     { [Function: runTranspilers]
       [length]: 5,
       [name]: 'runTranspilers',
       [arguments]: null,
       [caller]: null,
       [prototype]: runTranspilers { [constructor]: [Circular] } },
     [length]: 5 ] }
---> Resolving symlinks
  ---> Resolving 'internal_packages/client-sync' to '/home/travis/build/nylas/nylas-mail/packages/client-sync'
  ---> Resolving 'spec/isomorphic-core' to '/home/travis/build/nylas/nylas-mail/packages/isomorphic-core/spec'
  ---> Resolving 'node_modules/isomorphic-core' to '/home/travis/build/nylas/nylas-mail/packages/isomorphic-core'
Packaging app for platform linux x64 using electron v1.4.15
---> Packaging for 1s
---> Packaging for 2s
---> Packaging for 3s
---> Packaging for 5s
---> Packaging for 6s
---> Packaging for 8s
---> Packaging for 10s
---> Packaging for 11s
---> Packaging for 12s
---> Packaging for 13s
---> Packaging for 15s
---> Packaging for 16s
---> Packaging for 17s
---> Packaging for 18s
---> Packaging for 19s
---> Packaging for 20s
Fatal error: ENOENT: no such file or directory, scandir '/tmp/nylas-build/electron-packager/linux-x64/nylas-linux-x64/resources/apm/node_modules/atom-package-manager'
npm ERR! Linux 4.8.12-040812-generic
npm ERR! argv "/home/travis/.nvm/versions/node/v6.9.5/bin/node" "/home/travis/.nvm/versions/node/v6.9.5/bin/npm" "run" "build-client"
npm ERR! node v6.9.5
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! nylas-mail-all@0.0.1 build-client: `grunt build-client --gruntfile=packages/client-app/build/Gruntfile.js --base=./`
npm ERR! Exit status 3
npm ERR! 
npm ERR! Failed at the nylas-mail-all@0.0.1 build-client script 'grunt build-client --gruntfile=packages/client-app/build/Gruntfile.js --base=./'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the nylas-mail-all package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     grunt build-client --gruntfile=packages/client-app/build/Gruntfile.js --base=./
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs nylas-mail-all
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls nylas-mail-all
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/travis/build/nylas/nylas-mail/npm-debug.log
The command "npm install && npm run build-client && npm run upload-client" exited with 1.
cache.2
store build cache
0.01s
9.52schanges detected, packing new archive
.
uploading archive
Done. Your build exited with 1.
johnramsden commented 7 years ago

I'm not sure if the build failing is anything related to this patch since the branch that I branched off of was failing to build as well. I've also been unable to successfully build on my local machine.