nylas / nylas-mail

:love_letter: An extensible desktop mail app built on the modern web. Forks welcome!

https://nylas.com/nylas-mail/

MIT License

24.8k stars 1.38k forks source link

Fixes #3108 - Elementary Loki #3555

Closed dweremeichik closed 7 years ago

dweremeichik commented 7 years ago

Elementary OS changed their release name when they released the "Loki" version of their OS. This change prevents Nylas from "installing" its repository for Loki. For versions previous to Loki, running lsb_release -s -i would return

elementary OS

In Loki, running lsb_release -s -i now returns

elementary

This PR allows for both versions. Note I thought a simple "or" would be more efficient than a regex, and seems like a better choice than "elementary"*

See:

3108

3155

dweremeichik commented 7 years ago

Looks like you have an issue with openssl on your CI. @jstejada

dweremeichik commented 7 years ago

Closed in favor of #3556.