nylas / nylas-mail

:love_letter: An extensible desktop mail app built on the modern web. Forks welcome!
https://nylas.com/nylas-mail/
MIT License
24.8k stars 1.38k forks source link

Bugfix - Code Signing Fix #3599

Closed GrayW closed 7 years ago

GrayW commented 7 years ago

Resolves: Issue #8 & Issue #9 (Possibly)

This pull request resolves the code signing build errors on TravisCI with an alternative solution from the original that Nylas had in place by using a simpified before_install and before_script section in the travis file. This is currently being done by using self signed certificates with the following information:

Type: Self-signed (Non verified) Name: nylas-mail-lives Expires: 27 June 2018, 20:28

Reverse engineering the original will take a bit longer. However, this alternative results in the following build status for both Linux & OSX:

Please let me know if there are any issues with this request.