nylas / nylas-mail

:love_letter: An extensible desktop mail app built on the modern web. Forks welcome!
https://nylas.com/nylas-mail/
MIT License
24.8k stars 1.38k forks source link

Spell check always corrects in English #535

Closed iammikey1 closed 8 years ago

iammikey1 commented 8 years ago

Hi!

I have a problem with the spelling: my language is set as spanish but it automatically turn on the corrector in english so it appears as wrong every single word.

captura de pantalla 2015-12-01 a las 22 21 11

bengotow commented 8 years ago

Hi @iammikey1 thanks for filing this. I've confirmed that right now, spellcheck is always in English.

iammikey1 commented 8 years ago

And there´s no way to change it or disable it ?

On Dec 1 2015, at 10:56 pm, Ben Gotow <notifications@github.com> wrote:

Hi @iammikey1 thanks for filing this. I've confirmed that right now, spellcheck is always in English.


Reply to this email directly or view it on GitHub.

mbilker commented 8 years ago

Isn't the spellcheck engine derived from Atom?

bengotow commented 8 years ago

This should be fixed in 9af40833accdc2beddf6fecad0a3e5261cfaffa9 - we use the same node-spellcheck module that Atom does, but we weren't initializing it with the user's current language.

mbilker commented 8 years ago

Hmm. The spec tests are failing under Linux with this merged in. My build is https://travis-ci.org/mbilker/N1/builds/95960482. I know running under Trusty does not change anything. My Arch Linux is also very similar and fails the build for the same 3 reasons.

koenpunt commented 8 years ago

Is there a possibility to make the spelling language differ from the system language? Because I'm having my Mac's language set to English, but I mostly e-mail in Dutch..

Muurtegel commented 8 years ago

I'm in a similar situation as @koenpunt. My Mac's language is set to English, but I send emails in several languages. Most apps seem to recognise what language I'm typing in and adjust the spelling check to that language.

mbilker commented 8 years ago

@Muurtegel Unfortunately for your case, N1 uses node-spellchecker which uses OS X's spellchecker extension, but it defaults to the primary language that is in navigator.language.

bartn commented 8 years ago

Just as @koenpunt and @Muurtegel I am struggling with the spell-checker for multi-languages.

jaap commented 8 years ago

Same issue as @bartn, @koenpunt and @Muurtegel, setting the spell-check language within N1 would be great.

mbilker commented 8 years ago

@jaap the spellchecker on Windows and OS X uses native API's to get spellchecking done. Multi-language support is not available yet.

lmartins commented 8 years ago

I see this is marked as fixed although im still having the problem in the latest release. Only me?

Muurtegel commented 8 years ago

Apparently it's fixed as in that it spell-checks in your system's language. So you could change the system language to change the spellcheck.

Ideally, we would like Multi-language support and some language detection.

lmartins commented 8 years ago

Ok, although that is hardly a definite solution. I have my system in English and spend all day writing both in Portuguese and English languages, so it should detect the language or if not possible at least allow the user to pick the language.

Muurtegel commented 8 years ago

I feel your pain, I write in Dutch and English. I hope there will be a good solution at some point.

koenpunt commented 8 years ago

If it would let you pick out the different navigator languages, as navigator.languages in Chrome returns an array of all languages defined in the settings. Although in Electron it's empty ([]), which is possibly related to this bug: https://bugs.chromium.org/p/chromium/issues/detail?id=570349#c4

Although we would still need an interface for switching the language.

nlenkowski commented 8 years ago

This issue should probably not be closed.

I'm in a similar frustrating situation here. I write in both Spanish and English daily, my OS language is English. Nylas refuses to spellcheck in Spanish consistently and provides no way to manually specify the message language. I don't have this problem in other email applications (Mail, Airmail, Polymail, etc) they auto-detect the language as I write. I'm on OS X El Capitan running Nylas 0.4.25-a22631a, the latest release to date.

lmartins commented 8 years ago

Theres a dedicated issue to this problem https://github.com/nylas/N1/issues/1392, that's why this one is closed:

nlenkowski commented 8 years ago

Thanks, didn't see this was a duplicate of #1392. Glad to see work on the issue is ongoing.