search

nylas / nylas-nodejs

A NodeJS wrapper for the Nylas REST API for email, contacts, and calendar.
MIT License
167 stars 117 forks source link

Implement logger support #508

Closed mrashed-dev closed 9 months ago

mrashed-dev commented 9 months ago

Description

This PR adds in an option to pass in a logger instead of the SDK using console to log. Closes #456.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8018c78) 91.70% compared to head (7258c0a) 91.55%.

:exclamation: Current head 7258c0a differs from pull request most recent head 163f0ce. Consider uploading reports for the commit 163f0ce to get more accurate results

Files Patch % Lines
src/nylas.ts 33.33% 4 Missing :warning:
src/nylas-connection.ts 50.00% 2 Missing :warning:
src/config.ts 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #508 +/- ## ========================================== - Coverage 91.70% 91.55% -0.16% ========================================== Files 62 62 Lines 2641 2651 +10 Branches 481 485 +4 ========================================== + Hits 2422 2427 +5 - Misses 218 223 +5 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.