search

nylas / nylas-nodejs

A NodeJS wrapper for the Nylas REST API for email, contacts, and calendar.
MIT License
166 stars 116 forks source link

Fix issue where Graph events were returning 400 on update #524

Closed mrashed-dev closed 6 months ago

mrashed-dev commented 6 months ago

Description

This PR remedies the issue seen where Graph accounts were returning 400 on update due to visibility field being present in the PUT request. We now check to see if the visibility field was modified, and only then do we include it in the outgoing request.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6586ab4) 91.75% compared to head (9301d09) 91.79%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #524 +/- ## ========================================== + Coverage 91.75% 91.79% +0.04% ========================================== Files 62 62 Lines 2656 2670 +14 Branches 487 490 +3 ========================================== + Hits 2437 2451 +14 Misses 218 218 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.