I encountered occasional application crashes and traced them back to timeouts coming from the Nylas API. After reviewing the Nylas-SDK, I found the culprit in the setTimeout call used to abort the request. It's bad practice to throw an error from setTimeout as its try...catch blocks will not intercept the error. Instead, these errors will crash the application.
node-fetch will reject when controller.abort() is called, so we don't need to throw from the timeout anyway.
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
I encountered occasional application crashes and traced them back to timeouts coming from the Nylas API. After reviewing the Nylas-SDK, I found the culprit in the
setTimeoutcall used to abort the request. It's bad practice to throw an error fromsetTimeoutas itstry...catchblocks will not intercept the error. Instead, these errors will crash the application.node-fetchwill reject whencontroller.abort()is called, so we don't need to throw from the timeout anyway.Reference: https://jaketrent.com/post/catch-error-thrown-settimeout/ https://nodejs.org/dist/latest-v7.x/docs/api/errors.html#errors_node_js_style_callbacks
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.