search

nylas / nylas-ruby

Ruby bindings for the Nylas Platform APIs
https://nylas.com/docs
MIT License
101 stars 130 forks source link

Fix calendar availability failing when `round_robin` is `nil` #375

Closed mrashed-dev closed 2 years ago

mrashed-dev commented 2 years ago

Description

This PR address the issue where, if round_robin is left as nil, it always yields an error. This is because the Nylas Docs were out of date for the availability endpoint. round_robin is optional, and when omitted, returns collective availability. However, sending null is not valid despite what it says in the documentation. Now, we omit the value from the json payload if the value is nil.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

quzhi1 commented 2 years ago

CI is failing

mrashed-dev commented 2 years ago

Thanks @quzhi1, CI is fixed now :)