search

nylas / nylas-ruby

Ruby bindings for the Nylas Platform APIs
https://nylas.com/docs
MIT License
101 stars 130 forks source link

Fix OAuth URL building #462

Closed atejada closed 9 months ago

atejada commented 9 months ago

Fix url_auth_builder call

Description

This line:

builder.query = URI.encode_www_form(build_query(config)).gsub!("+", "%20")

Replaces the whole value, so the Auth doesn’t work.

Replaced it with this:

builder.query = URI.encode_www_form(build_query(config)).gsub(/\+/, "%20")

https://nylas.atlassian.net/browse/TW-2543

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (eeb47e8) 99.84% compared to head (1378047) 99.84%.

:exclamation: Current head 1378047 differs from pull request most recent head db13ed0. Consider uploading reports for the commit db13ed0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #462 +/- ## ========================================== - Coverage 99.84% 99.84% -0.01% ========================================== Files 24 24 Lines 664 658 -6 ========================================== - Hits 663 657 -6 Misses 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.