search

nylas / sync-engine

:incoming_envelope: IMAP/SMTP sync system with modern APIs
https://nylas.com/docs/platform
GNU Affero General Public License v3.0
3.5k stars 354 forks source link

Add installation instructions of sync engine on DigitalOcean Droplet to README.md #326

Closed adamporter closed 7 years ago

adamporter commented 8 years ago

Fixes # N/A

Summary: Adds detail to the README.md file to help others install the sync engine to a DigitalOcean Droplet.

Test Plan: N/A

Reviewers: @grinich

adamporter commented 8 years ago

Hmm. Updating the README.md shouldn't have failed the Travis build.

pfista commented 8 years ago

Try rebasing on master again, the failure was due to a lint error that is fixed now.

adamporter commented 8 years ago

Biffed my local copy. Reset to upstream and recommitted my changes. Let's give this a whirl.

khamidou commented 8 years ago

Hi @adamporter,

Thanks for taking the time to send this pull request!

I'm not an expert about using DigitalOcean w/ vagrant but I'm not seeing anything about securing the box here --- how do you prevent people from reading your emails (i.e: by putting Nginx + SSL in front of inbox-api and disallowing access to /accounts) or trying to ssh into your instance?

Cheers!

YurySolovyov commented 8 years ago

I wonder if its possible to use docker as engine to make it a bit more lightweight

adamporter commented 8 years ago

@YurySolovyov Here's a repo working toward that goal: https://github.com/nylas/sync-engine-docker

@khamidou Excellent questions. I must admit, I don't have all the answers. I had assumed that droplet security would be a separate concern, given that similar security measures would be taken with or without the sync engine in place. If you'd like, I can post my thoughts and links from DigitalOcean that address droplet security?

YurySolovyov commented 8 years ago

@adamporter the repo seems to have low activity, I guess it is not the Nylas team focus for now.

adamporter commented 8 years ago

@YurySolovyov That's correct. The README on that page actually says:

Note this is not officially supported by Nylas.

YurySolovyov commented 8 years ago

@adamporter yeah, but no official support !== stalled. :smile: I still think this PR is useful. Thanks.

adamporter commented 8 years ago

@YurySolovyov No problem at all. My perspective is that there's low community interest, which means low value to the business. Why spend resources on features that aren't in high demand?

So, they're relying on the community to contribute. If you want it to work, help make it work. :+1:

spang commented 7 years ago

Hi there,

Given the lack of activity on this PR in the last 6 months, I'm going to go ahead and close it for now.

Feel free to reopen with a version that addresses the security concerns!