cleanup(*): rm refs to Inbox that refer to company, not inbox

nylas / sync-engine

:incoming_envelope: IMAP/SMTP sync system with modern APIs

https://nylas.com/docs/platform

GNU Affero General Public License v3.0

3.5k stars 354 forks source link

cleanup(*): rm refs to Inbox that refer to company, not inbox #330

Closed bengotow closed 8 years ago

bengotow commented 8 years ago

Summary:

This diff replaces references to inbox and inbox_uid that referred to the company name, not the actual Inbox. (About half of the occurrences of inbox_uid DO refer to the inbox.) This confused me for a few minutes when reviewing some draft sync code.

To avoid any schema level changes I just alias the inbox_uid of the Message object to nylas_uid.

Corresponding EAS changes are in: https://github.com/nylas/sync-engine-eas/pull/1

Test Plan: Run existing tests

spang commented 8 years ago

I really think we should consider using the column aliasing technique I mentioned. Other than that, lgtm! Thanks for cleaning this up. :)