nylas / sync-engine

:incoming_envelope: IMAP/SMTP sync system with modern APIs
https://nylas.com/docs/platform
GNU Affero General Public License v3.0
3.5k stars 354 forks source link

Add environment variable so binaries work; tweak install script #461

Open uberbrady opened 6 years ago

uberbrady commented 6 years ago

I was trying to run this using the Vagrant method and I got some errors, so I thought I would just try and fix them.

First, the default version of pip that's already installed seems to try to install from the non-TLS version of the python repositories.

Next, the Python chardet library version that the system wants conflicts with one that's already installed on Ubuntu. I just uninstalled the package so the new one can get put in instead.

I also disabled the pip version check, it just makes for confusing errors.

And the last change to the setup.sh script is - because of how upstart is hooked into the system, mysql seems to start on its own and the mysqld_safe binary doesn't need to be run directly.

Additionally, I modified the Vagrantfile to make the various binaries run as documented in the README. I adding a profile.d script to set the PYTHONPATH environment variable so those various binaries will execute correctly.

That last change seems weird; if that was something that was necessary I would expect it to already be there? If there's a better or different way to do that, I'm happy to rework my changes here to accommodate.