Skin ID Processing and Folder Structure Improvements

[koobzaar]

Background

We've been working on a tool to process League of Legends skin data, including renaming and organizing skin folders. Recent changes have introduced some issues and misalignments in our collaboration process.

Current Issues

1. Skin ID Processing Order:

   • The current C++ implementation is processing skin IDs in an unexpected order: 0, 1, 10, 11, 12, .. 19, 2, 20, ..., 29, 3, 30
   • This leads to incorrect skin ID assignments, affecting the usability for skin hack development.

2. Folder Renaming with Data Dragon:

   • Recent changes include renaming folders using Data Dragon, which wasn't expected.
   • This change impacts the expected folder structure and naming convention.

3. Chroma Handling:

   • The current implementation doesn't properly handle or label chromas, making it difficult to identify specific chroma variants.

Proposed Solutions

1. Fix Skin ID Processing:

   • Ensure that skin IDs are processed in the correct numerical order: 0, 1, 2, 3, ..., 9, 10, 11, ..., 28, 29, 30

2. Folder Structure and Naming:

   • Maybe revert to using only skin IDs for folder names without renaming based on Data Dragon.
   • Consider using the indexer.py to rename and compress to .fantome file

3. Chroma Handling:

   • Implement a system to properly index and label chromas.
   • Consider using the indexer.py script to handle chroma naming and organization.

Action Items

• [x] Fix the skin ID processing order in the C++ implementation.
• [x] Revert folder naming to use only skin IDs.
• [ ] Change indexer.py to support the correct names of the chromas

Additional Notes

• The recent changes have significantly altered the program's functionality.
• Consider separating the skin extraction/organization logic from the fantome generation process for more flexibility.