search

nylonee / watchlistarr

Customizable sync of Plex Watchlist to Sonarr/Radarr
GNU General Public License v3.0
198 stars 15 forks source link

ImportListExclusionController | API call made to deprecated endpoint #128

Open jamcalli opened 7 months ago

jamcalli commented 7 months ago

Watchlistarr is causing Sonarr to spit out the following warning logs. Probably not a big deal, but just something I noticed.

ImportListExclusionController | API call made to deprecated endpoint from http4s-ember/0.23.23

Great project!

nylonee commented 7 months ago

Oohh this is good spotting!

You are right, in the Sonarr API docs the standard ImportListExclusion call has been deprecated Screenshot 2024-04-11 090311

It looks like we now are expected to use the paginated version.

However since we use the same API call for all Sonarr calls, I'm confused as to whether this applies to Sonarr v3 and v4, or only v4 (or only v3?!) I'll have to do some more investigation and determine what's the best non-breaking way of implementing this change

nylonee commented 7 months ago

Looks like this is the PR that introduced the changes, I think that's only Sonarr v4

The best thing to do at the moment is to not do anything, as this will make the Watchlistarr client deviate, and we'll need to keep track of which version of Sonarr the user is using.

In the future we can explore doing this (or having fallback API calls), but it's probably low-ish priority at the moment :)

AhmedNSidd commented 6 months ago

+1 for this issue. It's becoming a hassle to read my Sonarr logs because of the pollution. I tried to work on this over the weekend but don't have enough competency over Scala or codebase to be able to do it.

stormshaker commented 3 months ago

Note this same warning is being logged in the Radarr logs too:

API call made to deprecated endpoint from watchlistarr/1.0
albinmedoc commented 3 months ago

This should be fixed as soon as possible. This causes several unnecessary IO operations every minute.