search

nymea / berrylan

Raspberry Pi WiFi setup
http://berrylan.org
GNU General Public License v3.0
335 stars 55 forks source link

Open Wifi networks not supported #6

Closed stigwoxholt closed 4 years ago

stigwoxholt commented 5 years ago

If i select a network that is open i get prompted to enter the password. It is not possible to get past this screen without entering a password. If i enter something and move on, it get a message saying i entered the wrong password.

Expected :

  1. Network list should show open networks ( it does today ) but add a small "open network icon" to them
  2. When i select a open network i am not prompted to enter password, just a question if i want to connect.
t-mon commented 5 years ago

Hi stigwoxholt. Thanks for your feedback! The open access point feature is still missing, because this tool is an excerpt from an actual product, which should never allow open wifi networks for security reasons. We created an open source tool out of it and the feature is on the roadmap! :)

maxpage92 commented 5 years ago

Hi there, if I wanted to add support for not needing a wifi password in the app, where would I change that? I have a use case, where many users won't have a wifi password set but still need to be able to connect. Any tips would be much appreciated :) thanks

mzanetti commented 5 years ago

Well, there's 2 places. One is nymea-networkmanager, which runs on the Raspberry Pi and receives the WiFi login detail, and the other is the Berrylan app. (In fact, there's 3 places, the BT-WiFi-Setup is also supported in nymea:app...)

If want to get going with contributing this, I'd recommend to first build BerryLan for your phone. Once that works, change it to allow setting up wifis without password. Start here: https://github.com/nymea/berrylan/blob/master/main.qml#L232 If the wifi does not require authentication (!d.currentAP.isProtected) instead of just going to the next page with swipeView.currentIndex++, you'd do the connectWirelessNetwork call right away with an empty password and skip the password page.

If you're lucky, nymea-networkmanager accepts it just like that. If not you'd then need to checkout the nymea-networkmanager/libnymea-networkmanager sources and change things there along the way until it does in a similar fashion.

mzanetti commented 4 years ago

I've added support for open wifis in the berrylan app, it'll be released with the next update. However, there is indeed something to be fixed in nymea-networkmanager too.

I'm closing this issue here now as it should work fine from an app perspective now. Please follow this bug to watch the issue in nymea-networkmanager: https://github.com/nymea/nymea-networkmanager/issues/22