search

nymea / nymea-mqtt

Nymea MQTT broker
GNU General Public License v3.0
7 stars 4 forks source link

Fix isConnected() and binary payload parsing #13

Closed timbz closed 3 years ago

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

mzanetti commented 3 years ago

Hey @timbz ,

thank you for the contribution. I'd need you to sign our CLA please in order to be able to accept your contribution.

If possible, please add the auto test (there are already auto-tests so adding one new one shouldn't be too hard). If you don't want that, I can also do that myself, please give me an example payload that would trigger this issue tho.

Thanks again. Much appreciated.

mzanetti commented 3 years ago

Just for you to know what will happen now. The branch is tagged as experimental and landing. This means it will be included in builds for the experimental and landing/testing package repository where testers will run the code for a bit now. So don't be surprised if this hangs around here for a bit, it doesn't mean we've forgotten about it. Once the next nymea release passed QA this will be merged.

timbz commented 3 years ago

Sounds good, thx for open sourcing this