Closed t-mon closed 1 year ago
The speedwire and sunny webbox code remaind mainly untouched and are simply ported from nymea-plugins.https://github.com/nymea/nymea-plugins-modbus/pull/95/commits/e4210add11aa3fc524c6c8b7c6621f325f77ecca.
New code can be found in the second commit (for review) https://github.com/nymea/nymea-plugins-modbus/pull/95/commits/8a3bbe8a2b193c7ac63b723bc27691740fe5a824
nymea-plugins-modbus pull request checklist:
[x] Make sure the pull request's title is of format "Plugin name: Add support for xyz" or "New plugin: Plugin name"
[x] Did you test the changes on hardware, if not (e.g. absence of required hardware), please mention a person to confirm it has been tested.
[x] Did you update the plugin's README.md accordingly?
[ ] Did you update translations (cd builddir && make lupdate)?
cd builddir && make lupdate
The speedwire and sunny webbox code remaind mainly untouched and are simply ported from nymea-plugins.https://github.com/nymea/nymea-plugins-modbus/pull/95/commits/e4210add11aa3fc524c6c8b7c6621f325f77ecca.
New code can be found in the second commit (for review) https://github.com/nymea/nymea-plugins-modbus/pull/95/commits/8a3bbe8a2b193c7ac63b723bc27691740fe5a824
nymea-plugins-modbus pull request checklist:
[x] Make sure the pull request's title is of format "Plugin name: Add support for xyz" or "New plugin: Plugin name"
[x] Did you test the changes on hardware, if not (e.g. absence of required hardware), please mention a person to confirm it has been tested.
[x] Did you update the plugin's README.md accordingly?
[ ] Did you update translations (
cd builddir && make lupdate)?