Add battery level reporting for Lumi weather sensor + Fix spelling errors for Lumi devices

nymea / nymea-plugins-zigbee

ZigBee related integration plugins for nymea

GNU Lesser General Public License v3.0

0 stars 3 forks source link

Add battery level reporting for Lumi weather sensor + Fix spelling errors for Lumi devices #83

Closed jrc closed 4 months ago

jrc commented 10 months ago

This PR adds battery level reporting for the Aqara Temperature and Humidity Sensor.

Concretely, the lumiWeatherSensor thing class JSON definition was modified to add battery state as well as batteryLevel and batteryCritical states.

This change has not yet tested been with actual hardware.

Additionally, spelling errors in the same JSON have been corrected: "leve" to "level" and "adress" to "address".

CLAassistant commented 10 months ago

All committers have signed the CLA.

mzanetti commented 8 months ago

Oh dear... I totally missed this one. I am so sorry. Seems the battery level reporting has been added meanwhile, but the spelling error fixes would still be appropriate. If you wish, please update this pull request to work again (basically just removing the conflicting battery stuff but keeping the spelling error fixes) and we'll get it landed.

Thank you very much for the contribution, and again, I'm very sorry for missing this.