Keba: Fix type mismatch warning on setState for phaseCount

nymea / nymea-plugins

A collection of plugins for the nymea IoT server.

GNU Lesser General Public License v3.0

22 stars 25 forks source link

Keba: Fix type mismatch warning on setState for phaseCount #706

Open t-mon opened 1 year ago

t-mon commented 1 year ago

nymea-plugins pull request checklist:

[x] Make sure the pull request's title is of format "Plugin name: Add support for xyz" or "New plugin: Plugin name"
[ ] Did you test the changes on hardware, if not (e.g. absence of required hardware), please mention a person to confirm it has been tested.
[x] Did you update the plugin's README.md accordingly?
[x] Did you update translations (cd builddir && make lupdate)?

mzanetti commented 1 year ago

Hmm... Just reading it I don't think that'll fix the issue... I mean, yes, it will get rid of the warning because a invalid QVariant will be converted to 0 on a toUint() but I suppose the actual issue in a different place, perhaps even the core or the app, in that it feeds the API with a invalid QVariant in the first place... Can we reproduce it somehow?