nymea / nymea-plugins

A collection of plugins for the nymea IoT server.
GNU Lesser General Public License v3.0
22 stars 25 forks source link

journalctl output should not contain username+password+ip information #707

Closed Danfro closed 1 year ago

Danfro commented 1 year ago

When running journalctl -b -r -u nymead and having my shelly devices registered with nymea, the log brings this block of info occasionally:

Jun 20 22:12:56 NAME nymead[858]:  D | Shelly: CoIoT multicast message for "Shelly3EM" : {
Jun 20 22:12:56 NAME nymead[858]:  D | Shelly: Status update message for "Shelly3EM"
Jun 20 22:12:55 NAME nymead[858]:  W | ThingManager: Error setting up Thing(ShellyPlugS, id: {ID}, ThingClassId: {ID}) Thing::ThingErrorHardwareFailure "Error connecting to Shelly device."
Jun 20 22:12:55 NAME nymead[858]:  D | Shelly: Error connecting to shelly: QNetworkReply::UnknownNetworkError "Host unreachable"
Jun 20 22:12:49 NAME nymead[858]:  D | Shelly: Connecting to "http://USERNAME:PASSWORD@IP.IP.IP.IP:80/settings?coiot_enable=true&coiot_peer=IP.IP.IP.IP:5683"
Jun 20 22:12:49 NAME nymead[858]:  D | Shelly: Could not find Shelly thing on mDNS. Trying cached address: QHostAddress("IP.IP.IP.IP")

I would think, even for debug log, it should not log full credentials unless the user is aware of that?

Danfro commented 1 year ago

I need to add, this message is likely because I do not have my ShellyPlugS plugged in somewhere.