search

nymous / pydantic-vault

A simple extension to Pydantic BaseSettings that can retrieve secrets from Hashicorp Vault
MIT License
52 stars 13 forks source link

feat: add ability to skip ssl verification or pass CA bundle #24

Closed raider444 closed 1 year ago

raider444 commented 1 year ago

Issue #16

raider444 commented 1 year ago

@nymous any chance this PR can be reviewed and merged soon?

nymous commented 1 year ago

Hey! Many thanks for the PR, with tests and docs! :heart: I did some touch-ups to it, mainly to replace the str_to_bool with Pydantic's parse_obj_as, which is not deprecated, returns actual booleans ^^', and since we depend on Pydantic anyway doesn't cost much. I also simplified the tests to keep only what they were about, and added some more to check the priority order.

Tell me what you think about it, and I'll be happy to merge!

raider444 commented 1 year ago

Hey! Many thanks for the PR, with tests and docs! ❤️ I did some touch-ups to it, mainly to replace the str_to_bool with Pydantic's parse_obj_as, which is not deprecated, returns actual booleans ^^', and since we depend on Pydantic anyway doesn't cost much. I also simplified the tests to keep only what they were about, and added some more to check the priority order.

Tell me what you think about it, and I'll be happy to merge!

Thanks! It looks reasonable.

nymous commented 1 year ago

Release 0.8.0 is out with this! Thank you again!