search

nymtech / nym

Nym provides strong network-level privacy against sophisticated end-to-end attackers, and anonymous transactions using blinded, re-randomizable, decentralized credentials.
https://nymtech.net
1.28k stars 234 forks source link

"pending_messages" and "recently_closed" should be periodically cleared. #426

Open jstuczyn opened 3 years ago

jstuczyn commented 3 years ago

This issue is very similar to https://github.com/nymtech/nym/issues/424 as it also refers to cleaning up stale data. However, this can apply to both socks5 client and network requester.

Both socks5 client and network requester keep track of ids of all 'recently' closed connections and messages received out of order (not to be confused with OrderedMessage. this ONLY refers to receiving 'Send' before a 'Connect'). However, that data is NEVER cleared meaning that at some point we can simply run out of memory. Also it can be relatively easily abused...

tommyv1987 commented 1 year ago

@jstuczyn - do you still see this being problematic now?

jstuczyn commented 1 year ago

@jstuczyn - do you still see this being problematic now?

yup, it's still very much a thing