search

nyo / scdl

Firefox add-on that adds a download button under SoundCloud tracks!
https://addons.mozilla.org/firefox/addon/scdl
10 stars 0 forks source link

Download button visible but non-functional #7

Closed GravisZro closed 7 months ago

GravisZro commented 7 months ago

Thanks for the quick update but despite the Download button now being visible, it doesn't actually do anything when clicked.

Here's the page/track where it doesn't work: https://soundcloud.com/vinivicimusic/universe-inside-me

nyo commented 7 months ago

Ah yes, good find, I have the problem too. It seems to be an issue with the browser-id3-writer lib, I'll look at it later today. It works with most of the other tracks right?

nyo commented 7 months ago

I found and resolved the issue, just released v2.2, tell me if it works now

GravisZro commented 7 months ago

Just tried it and upon clicking it print the following to the console but no download occurs.

Some cookies are misusing the recommended “SameSite“ attribute 3

[scdl] Trying with 'progressive' transcoding ('audio/mpeg' MIME type)... index.js:237:12

This one song appears to be cursed. :)

nyo commented 7 months ago

I just tried with the latest version of the add-on and it worked for me. Sometimes it takes 2-3 sec to open the dialog window, but when it logs Trying with 'progressive' transcoding ('audio/mpeg' MIME type)... with no additional error it means it should work. 🤔

GravisZro commented 7 months ago

I checked closer and it was saving it! It wasn't notifying me because of a configuration issue. My bad.