IE 11 support - Githubissues

nypl-spacetime / Leaflet.GeotagPhoto

Leaflet plugin for photo geotagging

http://spacetime.nypl.org/Leaflet.GeotagPhoto/examples/camera.html

MIT License

70 stars 22 forks source link

IE 11 support #12

Closed mmmenno closed 7 years ago

mmmenno commented 7 years ago

In Leiden, a stunning 20% of the website visitors are using Internet Explorer 11 instead of a browser. These people don't see anything (no camera or target icons, map-to-camera-and-vv-icons) - see attached screendump. Do you think this is something that could easily be fixed?

bertspaan commented 7 years ago

Yes, I think so. However, I don't have IE so I cannot test or fix it easily myself. Can you try to see what the problem is? Errors in console? Weird placement of markers?

erfgoedleiden commented 7 years ago

I guess it's a HTTPS-issue :) I've tried it on two different computers, and they both give the same errors:

bertspaan commented 7 years ago

But that would not cause the camera + target to not be there.

This would:

I'll see if I can fix both the errors!

bertspaan commented 7 years ago

@mmmenno published new version 0.3.4 - does it work now?

bertspaan commented 7 years ago

I think that the HTTPS issue is caused by the fact that your website is served using HTTPS, but the tiles are using standard HTTP. This is not related to Leaflet.GeotagPhoto.

mmmenno commented 7 years ago

@erfgoedleiden If you are near an IE11 browser, could you check if it's working now?

erfgoedleiden commented 7 years ago

http://spacetime.nypl.org/Leaflet.GeotagPhoto/examples/camera.html gives the same result virtualbox_windows_7_10_03_2017_18_49_48

Console: SCRIPT438: Object doesn't support property or method 'assign' File: Leaflet.GeotagPhoto.min.js, Line: 1, Column: 5269

bertspaan commented 7 years ago

Ah! I fixed only half of the problem! Wait, new version is coming!

phpetra commented 7 years ago

@erfgoedleiden Have you by any chance also cleared the browser cache?

bertspaan commented 7 years ago

New version! Does it work now?

erfgoedleiden commented 7 years ago

Console: SCRIPT438: Object doesn't support property or method 'includes' File: Leaflet.GeotagPhoto.min.js, Line: 1, Column: 13889

bertspaan commented 7 years ago

We'll get there! Can you try again?

erfgoedleiden commented 7 years ago

The camera is working!

It is however not possible to adjust the angle.

bertspaan commented 7 years ago

Any errors when you move the slider?

bertspaan commented 7 years ago

Oh, I think this is the problem!

bertspaan commented 7 years ago

I've updated example - can you try again?

erfgoedleiden commented 7 years ago

Everything works perfectly 👍

phpetra commented 7 years ago

Quick fix, Bert. Thanks!