search

nypl-spacetime / Leaflet.GeotagPhoto

Leaflet plugin for photo geotagging
http://spacetime.nypl.org/Leaflet.GeotagPhoto/examples/camera.html
MIT License
70 stars 22 forks source link

Default icons does not work over CDN #15

Closed Abbe98 closed 4 years ago

Abbe98 commented 5 years ago

The default icon URLs remains(relative URLs) and it results in images being expected on the current domain such as https://example.com/images/crosshair-icon.svg.

The CDN version should have absolute URLs as defaults for icons and other resources.

bertspaan commented 5 years ago

Hey @Abbe98, I'm the author of this Leaflet plugin, but I no longer work for the NYPL and I no longer have write access to this repository. And nobody else at NYPL is maintaining this repo, I'm afraid.

If you would make a PR, I can reach out to my former colleagues and see if one of them can accept it.

Abbe98 commented 5 years ago

@bertspaan do you think it would be possible to move it to a new home? I know that Ajapaik is looking into adopting this library and I intend to use it in a Wikimedia related project soonish...

I will, however I'm likely to make additional ones in the future and NPM would need to be updated as well...

bertspaan commented 5 years ago

Yes, we could move it to a new home (my own GitHub account, or somewhere else). Three things need to happen:

  1. I need to tag this repo as archived and put a link to the new one;
  2. NPM needs to be updated;
  3. We need to notify the Leaflet community and update the link on their plugins page.

What do you think would be a good, new home? Shall I just fork it? I can make you a collaborator on that repo if you want?

bertspaan commented 5 years ago

Apparently, I already forked the repo a year ago: https://github.com/bertspaan/Leaflet.GeotagPhoto.

What about using that one? I will reach out to my former NYPL colleagues for steps 1 and 2.