search

nypl-spacetime / nypl-warper

NYPL Map Warper
MIT License
43 stars 13 forks source link

bug - can't type space in comments box #62

Closed lklepner closed 8 years ago

lklepner commented 8 years ago

I'm unable to use spaces in the comments box (tested using Chrome) http://maps.nypl.org/warper/maps/14719#Comments_tab

mgiraldo commented 8 years ago

also on Firefox

scspaeth commented 8 years ago

I got a similar result using Firefox and discovered that it would not let me left-arrow back through text to revise what I had written. http://maps.nypl.org/warper/maps/12966#Comments_tab

mgiraldo commented 8 years ago

yeah it is broken :\

mgiraldo commented 8 years ago

apparently it is related to jQuery UI tabs being used. it allows users to move from tab to tab using arrows (it is somewhat broken, though) and other widgets make use of the spacebar

i'm not a fan of jQuery UI, but not sure what will break by removing it (the tabs will surely break, i suppose)

it used to work, though, since some comments do have spaces (maybe related to recent keyboard navigation improvements?)

lklepner commented 8 years ago

It appears to be related to the OpenLayers keyboard controls.

This was confirmed by reverting to a commit prior to enabling the keyboard controls and it works correctly.

I can look into resolving it towards the end of the week.

mgiraldo commented 8 years ago

fixed in b2ab6f321178aa12344623454481b757c92fdc39