search

nypublicradio / ember-hifi

The easy way to play audio in your ember app
MIT License
45 stars 10 forks source link

Usage in addons #70

Closed teejayhh closed 4 years ago

teejayhh commented 5 years ago

Hello, I am wondering if this addon works in addons. Usually if an addon like ember-hifi is not included in an app but an addon then we need to move the dependency into the dependency section of the addons package.json. Doing this, fails to start up the ember s of the application

app1
--- addon1
------ ember-hifi

ember s (app1) ->

~/b/f/a/client git:hifi-test ❯❯❯ ember s                                                   ✭ ✚ ✱
Cannot read property 'connections' of undefined

Can anyone anyone confirm this bug?

jkeen commented 4 years ago

@teejayhh It definitely does work in addons, as NYPR is using them in many internal addons. https://github.com/nypublicradio/nypr-audio-services/blob/master/package.json

But yeah, looks like currently you've gotta have it in dependencies. Not sure why it's giving you that error. What do you have set in your environment file?

teejayhh commented 4 years ago

I am not using it anymore, as it wasn't working for me. I don't have the time atm to test this out again so I guess we can close this.