nystudio107 / craft-icalendar

Tools for parsing & formatting the RFC 2445 iCalendar (.ics) specification
MIT License
8 stars 2 forks source link

Outlook ICS failed to open stream: HTTP request failed #32

Closed chrisrowe closed 2 years ago

chrisrowe commented 2 years ago

Hitting this issue from the ics-parser dependency https://github.com/u01jmg3/ics-parser/issues/311.

I've forked and referenced commit hashes in my composer since I need this urgently but I'm opening this issue here as a polite request to update to the latest version when it's released please.

khalwat commented 2 years ago

Based on the semVer, you should automatically get that update when it is released: https://github.com/nystudio107/craft-icalendar/blob/develop/composer.json#L26

chrisrowe commented 2 years ago

3.1.2 does not satisfy constraint ^2.1.0

khalwat commented 2 years ago

I was going off of it being added to the 2.x.x milestone:

u01jmg3 added this to the v2.x.x milestone 12 days ago

If that's incorrect or does not happen, I'm happy to re-open this issue.

chrisrowe commented 2 years ago

https://github.com/u01jmg3/ics-parser/releases v2x hasn't had any releases since 02 Nov 2020 despite many issues in that milestone being closed since then. The milestone is also "Past due by almost 5 years" so I wouldn't assume much.

khalwat commented 2 years ago

Gotcha. Have you tried manually changing the semVer to ^3.0.0 to see if the rest of the plugin works with the new version of ics-parser or if additional refactoring is needed?

I scanned the README but didn't see any kind of an upgrade guide from 2 to 3, in terms of breaking changes.

Hah, that's funny, I was looking over the commit history, and it looks like I did a PR to this repo... I don't even remember doing it: https://github.com/u01jmg3/ics-parser/issues/273

chrisrowe commented 2 years ago

I haven't checked thoroughly but it works for my needs, I know there are many edge cases and quirks to ics files.

khalwat commented 2 years ago

And away we go:

Craft 3: https://github.com/nystudio107/craft-icalendar/releases/tag/1.1.3

Craft 4: https://github.com/nystudio107/craft-icalendar/releases/tag/4.0.0

chrisrowe commented 2 years ago

Thanks Andrew!