search

nystudio107 / craft-instantanalytics-ga4

Instant Analytics brings full Google GA4 server-side analytics support to your Twig templates and automatic Craft Commerce integration
Other
3 stars 4 forks source link

Fix client & session COOKIE #13

Closed Romanavr closed 1 year ago

Romanavr commented 1 year ago

Description

This PR fixes the session and the client cookie. I have tested it and can confirm that it works for me. Also fixes an issue where the measurement ID when is set as .env variable

Related issues

https://github.com/nystudio107/craft-instantanalytics-ga4/issues/12

khalwat commented 1 year ago

Looks like the PR conflicts with some of the changes made recently. I'll look at reconciling

Romanavr commented 1 year ago

Looks like the PR conflicts with some of the changes made recently. I'll look at reconciling

I see that one of your crew has made changes. Decide what's best to do, thanks anyway.

khalwat commented 1 year ago

Really appreciate the PR, but we fixed this issue (hopefully!) in a slightly different way. Let me know if you have any issues:

Craft 3: Version 3.0.0-beta.3 -> https://github.com/nystudio107/craft-instantanalytics-ga4/releases/tag/3.0.0-beta.3

Craft 4: Version 4.0.0-beta.4 -> https://github.com/nystudio107/craft-instantanalytics-ga4/releases/tag/4.0.0-beta.4