This could lead to issues and should be addressed in the plugin's documentation, since otherwise the function does not extract the hash as intended.
In addition to that strpos might not be a proper function for determining the hash itself since the initial filename could be written in kebap case and strpos returns the first occurrence of a given character. Therefore my suggestion would be to take strrpos instead, as well as for determining the initial hashPos.
All in all it might even be better to give the developer the opportunity to define a custom hash prefix by for example an environment variable, since vite also allows custom naming of the output files using rollup. https://rollupjs.org/configuration-options/
khalwat
commented
2 months ago
Description
It seems to have been forgotten that vite uses base64 naming for the bundle prefix by default, which includes special characters such as
-: https://rollupjs.org/configuration-options/#output-hashcharactersThis could lead to issues and should be addressed in the plugin's documentation, since otherwise the function does not extract the hash as intended.
In addition to that
strposmight not be a proper function for determining the hash itself since the initial filename could be written in kebap case andstrposreturns the first occurrence of a given character. Therefore my suggestion would be to takestrrposinstead, as well as for determining the initialhashPos.All in all it might even be better to give the developer the opportunity to define a custom hash prefix by for example an environment variable, since vite also allows custom naming of the output files using rollup. https://rollupjs.org/configuration-options/
Kind regards
Related issues