nystudio107 / craft-retour

Retour allows you to intelligently redirect legacy URLs, so that you don't lose SEO value when rebuilding & restructuring a website
https://nystudio107.com/plugins/retour
Other
39 stars 26 forks source link

Wrong `fileNotFoundUrl`in Dashboard #290

Closed vandres closed 3 weeks ago

vandres commented 4 months ago

Question

We are having a multi-site setup. We have 6 different sites, with 2 different domains and 2 languages.

image

Now our editors reported some wrong urls. I am not even sure, if it was always like this (since #241) or came with one of the updates.

One example url is "http://zs.test/shop/ch/reinigung-der-inneren-organe123.html" This creates a new entry in the Dashboard.

grafik

But when you click on it in the Dashboard, it actually adds the complete baseUrl to the link.

Bildschirmfoto 2024-02-07 um 18 26 58

Right now, when the editors click onto the link, they directly generate a new 404 because of the wrong url "http://zs.test/shop/shop/ch/reinigung-der-inneren-organe123.html"

vandres commented 4 months ago

I think, it comes from this change: https://github.com/nystudio107/craft-retour/blame/728fd728405f68c8ba105e7767743f16d958d744/buildchain/src/vue/FileNotFoundUrl.vue#L32

khalwat commented 4 months ago

Same as: https://github.com/nystudio107/craft-retour/issues/294

vandres commented 3 months ago

@khalwat Is there any ETA on this?

khalwat commented 3 months ago

I'm in the midst of getting plugins ported to Craft 5, but it's on the list!

khalwat commented 3 weeks ago

Addressed in the above commits

Craft CMS 3:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-retour": "dev-develop as 3.2.16”,

Then do a composer clear-cache && composer update

…..

Craft CMS 4:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-retour": "dev-develop-v4 as 4.1.17”,

Then do a composer clear-cache && composer update

…..

Craft CMS 5:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-retour": "dev-develop-v5 as 5.0.1”,

Then do a composer clear-cache && composer update