search

nystudio107 / craft-scripts

Shell scripts to manage database backups, asset backups, file permissions, asset syncing, cache clearing, and database syncing between Craft CMS environments
https://nystudio107.com/
MIT License
362 stars 61 forks source link

Improve bash scripts #34

Closed preposthuman closed 6 years ago

preposthuman commented 6 years ago

Making style more consistent

khalwat commented 6 years ago

Thanks @preposthuman this is great! I assume the [ -> [[ is because of http://mywiki.wooledge.org/BashFAQ/031 ?

preposthuman commented 6 years ago

Yes, mostly because if you always default to [[]], then you'll never be unpleasantly surprised by unexpected behavior. It also has all those extra test modes.

preposthuman commented 6 years ago

Also, I've got plenty of bigger refactors in mind, if you're interested. I just wanted to get the easy stylistic changes done first.

khalwat commented 6 years ago

Let me merge and QA test this first, but yeah absolutely I'm totally open to a more complete refactoring.

khalwat commented 6 years ago

Thanks again!