nystudio107 / craft-seomatic

SEOmatic facilitates modern SEO best practices & implementation for Craft CMS 3. It is a turnkey SEO system that is comprehensive, powerful, and flexible.
https://nystudio107.com/plugins/seomatic
Other
165 stars 69 forks source link

[FR] Support Vizy fields as meta source fields #1115

Open yoannisj opened 2 years ago

yoannisj commented 2 years ago

Describe the bug

Vizy fields don't appear in source field dropdowns in the Content SEO settings for entry sections.

To reproduce

  1. Add a Vizy field to a given Entry Type
  2. Go to SEOMatic > Content SEO > Entry Section from Step 1
  3. Select the Entry Type from Step 1 in the dropdown on the top left
  4. Select "SEO Description Source > From Field"
  5. Open the "Source Field" dropdown
  6. The Vizy field from Step 1 is not listed in the dropdown options

Expected behaviour

Vizy fields can contain text which may be useful for SEO descriptions. It would be great if we could select Vizy fields as SEO field sources, for both the "From Field" and "Summary from Field" options.

Versions

khalwat commented 2 years ago

Changing this to a feature request

engram-design commented 2 years ago

@khalwat Is there a mechanism for me to add support for Vizy fields, or is that all more or less hardcoded on your end?

khalwat commented 2 years ago

Hard-coded-ish on my end, but shouldn't be too hard for me to add here: https://github.com/nystudio107/craft-seomatic/blob/develop/src/helpers/Field.php & https://github.com/nystudio107/craft-seomatic/blob/develop/src/helpers/Text.php

yoannisj commented 1 year ago

Just realised that it would make sense to support Vizy field as source for Asset fields in sitemaps:

We often use Vizy fields as rich text fields (i.e. without adding any block type) because of how it stores the formatted the text as JSON (which gives us more control on how to render the field in the frontend).

For example: in the screenshot below Assets in the "Images" volume have a block-less Vizy field named "Description" where editors can add a caption to the images. The text stored in that field would be the best match for the Asset's "Caption" field in sitemaps, but it is currently not selectable:

ScreenShot 2022-10-17 at 11 21 30

gregorydavidjenkins commented 1 year ago

Would also love to be able to add a Vizy field as the source for SEO description. Specifically "Summary from field".

khalwat commented 1 year ago

Very doable

torgeirbeyer commented 1 year ago

Any updates on this?

khalwat commented 1 year ago

I'm planning to slate this for the next release!

torgeirbeyer commented 9 months ago

Has this been released @khalwat ?

khalwat commented 9 months ago

Not yet; sorry for promising it in the next release, and not delivering.