nystudio107 / craft-seomatic

SEOmatic facilitates modern SEO best practices & implementation for Craft CMS 3. It is a turnkey SEO system that is comprehensive, powerful, and flexible.
https://nystudio107.com/plugins/seomatic
Other
162 stars 68 forks source link

Creator id fix #1431

Closed JeroenOnstuimig closed 3 months ago

JeroenOnstuimig commented 3 months ago

Description

When the creator url is different from the identity url, the references to the creator entity would be wrong. Truncated example:

{
      "@type": "WebSite",
      "author": {
        "@id": "https://example.com#identity"
      },
      "copyrightHolder": {
        "@id": "https://example.com#identity"
      },
      "creator": {
        "@id": "https://example.com#creator"
      },
      "publisher": {
        "@id": "https://example.com#creator"
      },
      "url": "https://example.com"
},
{
      "@id": "https://example.com#identity",
      "@type": "Organization",
      "name": "Example",
      "url": "https://example.com"
},
{
      "@id": "https://onstuimig.nl#creator",
      "@type": "Organization",
      "name": "Onstuimig",
      "url": "https://onstuimig.nl"
},

This PR makes sure all references to #creator use the creator url

khalwat commented 3 months ago

Thank you for the PR, I will port it to the Craft 3 & Craft 5 versions of the plugin!