search

nystudio107 / craft-seomatic

SEOmatic facilitates modern SEO best practices & implementation for Craft CMS 3. It is a turnkey SEO system that is comprehensive, powerful, and flexible.
https://nystudio107.com/plugins/seomatic
Other
165 stars 69 forks source link

Cannot use ::class with dynamic class name #1436

Closed ArpadGBondor closed 6 months ago

ArpadGBondor commented 6 months ago

Describe the bug

We keep getting an error thrown from a dependency of this package: Cannot use ::class with dynamic class name

It is coming from here: /nystudio107/craft-code-editor/src/autocompletes/SectionShorthandFieldsAutocomplete.php:167

I think it is this line in the current version: https://github.com/nystudio107/craft-code-editor/blob/d2d9c8706fc1a6f40253fc78762101ce9b5ac386/src/autocompletes/SectionShorthandFieldsAutocomplete.php#L174

Expected behaviour

I think something like this would solve it: https://github.com/nystudio107/craft-twigfield/commit/bff508e2e239fd55b8a17ea56fc60db5e655f418

I raised a ticket under the plugin's repo, but after the bug got fixed, the version of the plugin should be bumped here too, so we can start using the solution. https://github.com/nystudio107/craft-code-editor/issues/7

Versions

khalwat commented 6 months ago

Yeah this will be fixed upstream in that package, so when you update it, SEOmatic will automatically get the changes. Follow it on the issue you filed over there: https://github.com/nystudio107/craft-code-editor/issues/7

I'm guessing it's specific to that version of PHP or such.

khalwat commented 6 months ago

Addressed in the above commit